Drop special behavior for legacy browsers #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
========================================
- Coverage 100% 98.3% -1.7%
========================================
Files 1 1
Lines 63 59 -4
Branches 19 17 -2
========================================
- Hits 63 58 -5
- Misses 0 1 +1
Continue to review full report at Codecov.
|
mathiasbynens
approved these changes
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the special handling of the
:character in CSS identifiers so that they simply escaped as\:, and also removes the special handling of leading_characters in identifiers so they are not escaped.Hopefully I've followed the build process properly, I noticed there were changes in
src/cssesc.jsthat hadn't been added to the build in/cssesc.js(namely the version number) so those changes were sort of brought in accidentally just by me running the build.